Handle MCCP1 non-standard SB terminator, fix nanvaent connection#6
Merged
Handle MCCP1 non-standard SB terminator, fix nanvaent connection#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IAC SB 85 WILL SEwhereSEappears without a precedingIAC. OurskipSBonly recognizedIAC SE, so the MCCP1 start marker was treated as an incomplete subnegotiation and buffered intelbuf— swallowing all subsequent data including the login banner.MCCP1constant (option 85) and aTeloptPatternto recognize and skip the 5-byte MCCP1 start sequence.Test plan
nanvaentNegotiationAndMCCP2— full replay of nanvaent's negotiation (split packets), verifies MSSP reception and banner textnanvaentCombinedMCCP2Packet— same replay with coalesced MCCP2 + compressed packetnanvaentInflateStreamDirectly— verifies InflateStream handles standard zlib format