Skip to content

Fix lint baseline where possible#11

Merged
powerje merged 8 commits intotrunkfrom
lint-baseline-phase2
Mar 10, 2026
Merged

Fix lint baseline where possible#11
powerje merged 8 commits intotrunkfrom
lint-baseline-phase2

Conversation

@powerje
Copy link
Copy Markdown
Member

@powerje powerje commented Mar 10, 2026

Summary

  • Migrate 7 dialog editors (Toast, Ack, Script, Gag, Replace, Notification, NewConnection) from Java/XML to Kotlin/Compose with shared EditorDialogScaffold
  • Delete 15 dead layout XML files and 31 duplicate drawable assets across density buckets
  • Fix ~500 mechanical lint issues: ContentDescription, Autofill, LabelFor, TextFields, ObsoleteLayoutParam, ButtonStyle, HardcodedText, UselessParent, Overdraw, RtlHardcoded, Deprecated, SpUsage, CutPasteId, MissingPrefix, SuspiciousIndentation, PluralsCandidate, MissingClass
  • Fix manifest class reference (com.happygoatstudios.btcom.offsetnull.bt for MainWindow)

Remaining 9 baseline issues

  • AndroidGradlePluginVersion (3) — AGP/Gradle upgrades tracked in issue #78
  • OldTargetApi (1) — targetSdk 35 is current; lint wants 36 which isn't stable
  • IconDensities (2) + IconMissingDensityFolder (1) — need xhdpi/xxhdpi drawable assets
  • SuspiciousIndentation (1) — persistent in MainWindow.java, may be false positive

Test plan

  • ./gradlew :BT_Free:assembleDebug builds successfully
  • App installs and launches on Pixel 10
  • Manual smoke test: launcher screen loads, connections list renders

@powerje powerje changed the title Reduce lint baseline from 524 to 9 warnings (98.3% reduction). Fix lint baseline where possible Mar 10, 2026
@powerje powerje force-pushed the lint-baseline-phase2 branch from 6aec062 to bfedfba Compare March 10, 2026 20:51
@powerje powerje merged commit 85e9700 into trunk Mar 10, 2026
1 check passed
@powerje powerje deleted the lint-baseline-phase2 branch March 10, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant