Add deprecation notices #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2017 10:29
Signed-off-by: Nathan Cerny <ncerny@chef.io>
Signed-off-by: Nathan Cerny <ncerny@chef.io>
wrightp
reviewed
May 26, 2017
| source_url 'https://github.com/ncerny/chef_stack' if respond_to?(:source_url) | ||
|
|
||
| version '0.8.6' | ||
| version '0.9.0' |
There was a problem hiding this comment.
I would suggest a patch release for the deprecation warnings. Users pinning to 0.8 will not see it. I also recommend the follow up patch release that truly deprecates this cookbook so it can't be used unless pinned specifically to 0.8.6.
Maybe fully deprecate in 30 days or so?
wrightp
reviewed
May 26, 2017
wrightp
left a comment
wrightp
left a comment
There was a problem hiding this comment.
Looks good. Just a comment on versioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nathan Cerny ncerny@chef.io