feat: add configurable custom header forwarding in proxy#2
Closed
oscartrullols wants to merge 1 commit intoallow-ip-rangesfrom
Closed
feat: add configurable custom header forwarding in proxy#2oscartrullols wants to merge 1 commit intoallow-ip-rangesfrom
oscartrullols wants to merge 1 commit intoallow-ip-rangesfrom
Conversation
Introduce serve.proxy.trust_custom_headers configuration key that accepts a list of custom HTTP header names to forward from the incoming request to the upstream. This complements the existing serve.proxy.trust_forwarded_headers boolean (which controls the standard X-Forwarded-* headers) by allowing arbitrary headers (e.g. X-Source-Port) set by trusted infrastructure to be preserved.
Member
Author
|
this fix is not needed... the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
serve.proxy.trust_custom_headersconfig key (list of strings) to forward arbitrary custom HTTP headers from the incoming request to the upstream.This complements the existing
trust_forwarded_headersboolean (which handles standardX-Forwarded-*headers) and is suitable for upstream contribution.Image:
registry.nearbycomputing.com/nearbyone/external/oryd/oathkeeper:v25.4.1-ips-custom-headers-alpine