Decouple certbot hooks from FORCE_RENEWAL #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the
renewscript, hooks (PRE_HOOK_CMD,POST_HOOK_CMD,DEPLOY_HOOK_CMD) are correctly handled as independent parameters. However, in thecertonlyscript, these same hooks are nested inside theFORCE_RENEWALconditional block.When a user sets up a new certificate, the hooks are ignored unless they also set
FORCE_RENEWAL=true.Using
CERTBOT_CERTONLY_FLAGSfor hooks would be possible in theory, but:It is currently subject to word splitting because the variable is not quoted when appended to the array:
certbot_params+=($CERTBOT_CERTONLY_FLAGS). This breaks any hook command containing spaces.Solution
This PR moves the hook parameters in the
certonlyscript outside of theFORCE_RENEWALblock. Thecertonlyscript now behaves like therenewscript.