Utility: use Fsdk

[webwarrior-ws]

Added fsdk package. Reuse functions from Fsdk.

Renamed FSharpUtil module to AsyncUtil.

Changed Retry function to take 1 type parameter instead of 2 as handling 2 types of exceptions is not needed anymore because SocketException is wrapped in NOnionException.

[aarani]

LGTM

[knocte]

@webwarrior-ws can you also fix the conventions job with a similar commit to this please: 37e374a7b03cb55b4718c46e65911f09c21f876b (and move it to be the first commit).

[webwarrior-ws]

Should be good now

[knocte]

LGTM

Please approve via GitHub PR approval process.

[knocte]

Please approve via GitHub PR approval process.

@aarani ^ otherwise I get "Merging is blocked" in the GitHub UI.

[webwarrior-ws]

Can't use Fsdk because it requires FSharp.Core 6.0, but NOnion uses 4.7.2 (in CI at least).

[knocte]

Upgrade FSharp.Core then?

[knocte]

Thinking about it more, please revert your last commit that removes NOnion.Utility.FSharpUtil.WithTimeout, but I want FSharpUtil module be gone from NOnion to prevent naming clash with Fsdk, so let's rename it to NetworkUtils.fs? (To be consistent with other files in that folder.) BTW I had a look at other files in that folder and I think ResultUtils.fs's OperationResult overlaps with FSharpUtil's Either, let's remove it and use Either. And same thing for the Unwrap function, I think FSharpUtil has Unwrap func? If not, let's move it to Fsdk.

[knocte]

Thinking about it more, please revert your last commit that removes NOnion.Utility.FSharpUtil.WithTimeout, but I want FSharpUtil module be gone from NOnion to prevent naming clash with Fsdk, so let's rename it to NetworkUtils.fs? (To be consistent with other files in that folder.) BTW I had a look at other files in that folder and I think ResultUtils.fs's OperationResult overlaps with FSharpUtil's Either, let's remove it and use Either. And same thing for the Unwrap function, I think FSharpUtil has Unwrap func? If not, let's move it to Fsdk.

Was this done?

[webwarrior-ws]

Thinking about it more, please revert your last commit that removes NOnion.Utility.FSharpUtil.WithTimeout, but I want FSharpUtil module be gone from NOnion to prevent naming clash with Fsdk, so let's rename it to NetworkUtils.fs? (To be consistent with other files in that folder.) BTW I had a look at other files in that folder and I think ResultUtils.fs's OperationResult overlaps with FSharpUtil's Either, let's remove it and use Either. And same thing for the Unwrap function, I think FSharpUtil has Unwrap func? If not, let's move it to Fsdk.

Was this done?

First part - yes, FSharpUtil is now called AsyncUtil.
OperationsResult is still there; it has different signature (1 type parameter instead of 2 in Fsdk.Either).