Naveego Code Challenge Plugin Solution in Node#1
Open
roehlerw wants to merge 9 commits intonaveego:masterfrom
Open
Naveego Code Challenge Plugin Solution in Node#1roehlerw wants to merge 9 commits intonaveego:masterfrom
roehlerw wants to merge 9 commits intonaveego:masterfrom
Conversation
Contributor
|
I've updated the host to compare dates correctly. I also added a more gnarly data file with only ten rows. For some reason your plugin publishes 21 rows from that file. |
Author
|
Added better schema inferring logic. It now looks at all records and picks the most common one for each column. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes all tests except for one bonus test related to datetime. I compared the expected and my actual and it looked like they were the same so I am not sure why that fails.
Needs to have robust error handling added.