-
Notifications
You must be signed in to change notification settings - Fork 1
Implement our own custom hasher #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f4231a8
6e37676
28761b3
e6336c5
1fc9bf5
72b1fb8
e377ee8
df3a21b
1f6577a
1fff344
5a4371a
934e6e7
da3a892
80653d1
8da263c
4730702
2b9da46
485a544
c2ff003
669647a
882adca
3f083ba
a908bba
9dce44e
616101b
3921886
bcb984c
535615f
115d80e
48cd2cb
5bb6414
ca3426c
08bc1f1
cb9cf80
9ce2993
81726f5
932abe1
58ac701
7728bfe
c2e2564
63fb32a
d4a233e
5a86fbc
b9b6384
45cb028
2f866e4
4f4b577
23fc982
bfa2b17
8b9db23
70effd5
3591940
26990d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: rust_checks | ||
| on: | ||
| - pull_request | ||
| jobs: | ||
| rust-syntax-style-format-and-integration: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| CARGO_TERM_COLOR: always | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Install Rust + components | ||
| uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: 1.91.1 | ||
| components: rustfmt,clippy | ||
| - name: Run syntax and style tests | ||
| run: cargo clippy --all-targets -- -D warnings | ||
| - name: Run format test | ||
| run: cargo fmt --check |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Generally I don't think we should include vscode settings, and if we were to do, we should keep it minimal to things that would be applicable to everyone.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A lot of it allow people who use VS code to have everything setup with the correct configuration like rust-analyzer, and formatting stuff. Ideally I want to keep it somewhere, but I can simplify it to the pure essentials.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's reduce this to bare minimal. There are definitely some entries like Python 3 interpreter path that shouldn't be set & expected to be the same across different working environments |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "[markdown]": { | ||
| "editor.defaultFormatter": null | ||
| }, | ||
| "editor.formatOnPaste": false, | ||
| "editor.formatOnSave": true, | ||
| "editor.rulers": [ | ||
| 100 | ||
| ], | ||
| "files.autoSave": "off", | ||
| "files.insertFinalNewline": true, | ||
| "gitlens.showWhatsNewAfterUpgrades": false, | ||
| "lldb.consoleMode": "evaluate", | ||
| "rust-analyzer.check.command": "clippy", | ||
| "rust-analyzer.checkOnSave": true, | ||
| "rust-analyzer.runnables.extraTestBinaryArgs": [ | ||
| "--nocapture" | ||
| ], | ||
| "rust-analyzer.rustfmt.extraArgs": [ | ||
| "--config", | ||
| "max_width=100" | ||
| ], | ||
| "notebook.formatOnSave.enabled": true, | ||
| "notebook.output.scrolling": true, | ||
| "python.terminal.activateEnvironment": false | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this just runs checks but not apply the formatting, does it? Shall we make it so that code gets auto-formatted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Vscode with the settings I set, it does auto format when you save. Unless you mean to let the github action force a commit to autoformat it?