Skip to content

feat: add project api key management#68

Merged
ianmeigh merged 24 commits intomainfrom
feat/project-api-keys
Sep 16, 2025
Merged

feat: add project api key management#68
ianmeigh merged 24 commits intomainfrom
feat/project-api-keys

Conversation

@MadhavM-117
Copy link
Contributor

Description of the change

Tickets

Dev checklist

  • PR addresses all ACs
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Added unit tests if necessary
  • Updated documentation if necessary
  • Self code review
  • Requested code review

Manual testing steps, if applicable

Please provide detail on the technical changes, if relevant

Screenshots/GIFs

Specific checklists

Unit tests
  • Added
Documentation
  • Updated build docs
  • Updated other technical docs such as tech spec or field spec
Browser testing
  • I have tested in the following browsers and environments (tick all that apply - not all changes will need testing in every browser)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
Accessibility
  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
Sustainability
  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered

@MadhavM-117 MadhavM-117 force-pushed the feat/project-api-keys branch 3 times, most recently from 4c5d0ba to 7fb3aa1 Compare September 14, 2025 21:30
@MadhavM-117 MadhavM-117 marked this pull request as ready for review September 14, 2025 21:45
Copy link
Collaborator

@ianmeigh ianmeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should we provide another view for users to see all projects to which they have API access? It is currently difficult to find this information.

@MadhavM-117
Copy link
Contributor Author

MadhavM-117 commented Sep 16, 2025

Question: Should we provide another view for users to see all projects to which they have API access? It is currently difficult to find this information.

@ianmeigh Ideally, yes.

But, I think that'll be something for later and out of scope for the current set of changes.

@MadhavM-117
Copy link
Contributor Author

@ianmeigh I've addressed your comments, and also prevent users from being removed from the Project if they have API Access.

I'm preventing removal instead of automatically removing the Project API access on membership revocation as I think it needs to be discussed and scoped out better to handle possible edge cases.

@ianmeigh ianmeigh force-pushed the feat/project-api-keys branch from 1d5534a to 9d2f714 Compare September 16, 2025 13:40
@ianmeigh
Copy link
Collaborator

ianmeigh commented Sep 16, 2025

Rebase with main and refactor title case to sentence case

@ianmeigh ianmeigh merged commit 97663b7 into main Sep 16, 2025
11 checks passed
@ianmeigh ianmeigh deleted the feat/project-api-keys branch September 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants