refactor: design update and code quality review#67
Merged
Conversation
6 tasks
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
3 times, most recently
from
fce1b14 to
88f6d34
Compare
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
from
e95ac38 to
41372b0
Compare
ianmeigh
commented
Sep 15, 2025
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
from
962b0fa to
3d10a88
Compare
MadhavM-117
reviewed
Sep 15, 2025
app/editor_ui/templates/editor_ui/feedback_forms/feedback_form_detail.html
Show resolved
Hide resolved
MadhavM-117
reviewed
Sep 15, 2025
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
from
34bcb4a to
8811a24
Compare
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
2 times, most recently
from
844fa92 to
565bb33
Compare
MadhavM-117
reviewed
Sep 16, 2025
app/editor_ui/templates/editor_ui/project_memberships/project_membership_list.html
Outdated
Show resolved
Hide resolved
MadhavM-117
reviewed
Sep 16, 2025
app/editor_ui/templates/editor_ui/feedback_forms/feedback_form_detail.html
Show resolved
Hide resolved
Additional changes to add missing mixins and attributes.
- Buttons are no longer icon-only on mobile viewports. - Buttons are all now in button groups for consistent spacing and sizing.
Clarify error messages when attempting to remove or update the last owner of a project.
Add new `normalised_domain` field to `Project` model with a unique constraint to prevent duplicate domains. This includes data migrations to populate the new field for existing records.
Help text is provided as a list on the reset page, which we cannot current format correctly in the form field help text.
ianmeigh
force-pushed
the
refactor/design-and-code-quality-review
branch
from
1667b28 to
2b6cebb
Compare
Collaborator
Author
|
Rebase with main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
When applied, this PR updates the design to match internal designs and address internal feedback. This roundup also includes changes to improve code quality and bug fixes.
Tickets
JIRA WE-126
Dev checklist
Manual testing steps, if applicable