Open
Conversation
Contributor
Author
|
@nathanrydel please let me know if we can use this PR as-is or if you need me to create any additional issues. While doing that, more ideas for tasks:
|
0dc32c4 to
757954d
Compare
757954d to
1875b4c
Compare
Contributor
Author
|
the branch is up-to-date with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #24 but while working on that, decided to separate User Provider logic.
The current PR is large but it will help to work with the
userin the future.What's implemented:
Paths
craco.configfile and prepare structure for further imports (Create React App Configuration Override for paths aliases) - did not work otherwise.The project can be further structured to have
pagesandcomponentsseparately insrcfolder.User Provider
App.js- it is now easy to readUserProvider, with types and correct structure, keeping the same logic/comments from App.js to refactor further when needed,MockUserProviderto enable testingdemoUserOther files
useLocalStorage- this would need further refactor, put the types as-is for now,UserProvider