Bump JSS to ^8.1.0#46
Bump JSS to ^8.1.0#46RikardGehlin wants to merge 6 commits intonathanmarks:masterfrom RikardGehlin:master
Conversation
|
as far as API surface isn't changed it's not a breaking change for consumers, but it's sort of big deal, so perhaps it's a minor release |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 94.11% 94.21% +0.09%
==========================================
Files 4 4
Lines 119 121 +2
==========================================
+ Hits 112 114 +2
Misses 7 7
Continue to review full report at Codecov.
|
|
i dont know how to fix flow errors |
|
@nathanmarks can you help? |
|
I think you should wait a bit, because @oliviertassinari is cooking something in this regard. |
|
sure, but we migrated it and fixed the breaking changes. we just dont know how to fix flow erros |
|
we need this because we need latest jss checked out in our projects for it to be possible to migrate to react-jss's theming |
|
btw, published as |
|
I'm working on a major styling upgrade on the Material-UI side, we would no longer rely on
|
|
@oliviertassinari thats cool, but we do use jss-theme-reactor without material-ui, so we need release of jss-theme-reactor to depend on latest jss, so we can migrate to react-jss's theming. can we get such a release? |
|
so, just clarify we dont need new material-ui release, we need new release of jss-theme-reactor |
|
@iamstarkov Oh but I don't have any admin right on this repository. |
|
@nathanmarks can you help? |
|
@nathanmarks ping |
Also fixed breaking changes from migration between 7.1.7 to 8.1.0 https://github.com/cssinjs/jss/blob/v8.1.0/changelog.md#800--2017-06-20
breaking changes were: