-
Notifications
You must be signed in to change notification settings - Fork 15
Remove deprecated version field from docker-compose files #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sva-s1
wants to merge
67
commits into
natesmalley:main
Choose a base branch
from
sva-s1:remove-docker-compose-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify requirements
Update requirements.txt
15 commits in one go sorry
updating requirements.txt to reflect changes in main branch
created an alert_generators directory and relevant subdirectories. moved zscaler-trigger-detections.py and alertgen.sh to their appropriate directories of the new structure. moved datagen.sh to the event_generators/shared directory
…rdening feat/hec parsing hardening
docs: add AGENTS.md contributor guide and whitelist in .gitignore
Delete goldenVersion-agent.json
- Fixed Tailwind CSS CDN loading error by specifying version 3.4.1 - Resolved backend API startup issues by adding missing dependencies - Fixed async/await JavaScript error in fetchScripts function - Added missing Python dependencies to requirements_simple.txt: * sqlalchemy, aiosqlite, greenlet for database operations * cryptography for encryption utilities * flask for frontend server - Removed non-existent validation router import from main.py - Fixed DOMContentLoaded async handler to prevent HTMLDocument errors - Created .env configuration for development environment These fixes ensure both frontend and backend services can run properly and communicate with authentication disabled for development. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Added init_db() call in application lifespan handler - Database tables are now created automatically on startup - Fixes 500 error when trying to save destinations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…d-integration-issues Fix frontend-backend integration issues
simplifying env deployment
- Fix typo in Frontend Dockerfile (requirments.txt → requirements.txt) - Create proper Frontend requirements.txt with flask dependency - Update Backend Dockerfile to use requirements_simple.txt - Ensure Docker builds will work correctly with proper dependencies 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Switch from requirements_simple.txt to requirements.txt - Use full dependency set for production builds 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Ephemeral Database Fix
removing trailing , characters
UI refactor
The API documentation is actually served at /api/v1/docs, not /docs. This commit updates the README to reflect the correct URL path for accessing the Swagger UI documentation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix API documentation URL in README
Fixes OSError read-only file system error in Docker containers
…donly-filesystem fix: write scenario files to writable /app/data directory
- Added optional event_time parameter to _envelope() and send_one() functions to allow setting specific event timestamps - Modified _envelope() to use provided timestamp or fallback to current time if not specified - Updated all function calls to pass through event_time parameter - Preserved existing behavior when no custom timestamp is provided This change enables more accurate event timing representation, particularly useful for: - Historical
Improbable travel with accepted Components to remove conflicting merge
- Added support for uploading .txt and .log files with line-by-line processing - Implemented gzip (.gz) file decompression with automatic file type detection - Added metadata field support to inject custom fields into generated events - Updated UI to include metadata field input with GUID generation helper - Enhanced HEC sender to handle custom metadata fields via --metadata argument - Added TLS compatibility options for older/misconfigured H
Adding ips that will trigger downstream impossible traveler alerts
endpoint is misspelled
endpoint is misspelled
- Added support for uploading .txt and .log files with line-by-line processing - Implemented gzip (.gz) file decompression with automatic file type detection - Added metadata field support to inject custom fields into generated events - Updated UI to include metadata field input with GUID generation helper - Enhanced HEC sender to handle custom metadata fields via --metadata argument - Added TLS compatibility options for older/misconfigured H
Fix typo in destination endpoint MAC output
Fix typo in output field name for MAC address
- Added new scenario "Insider Data Exfiltration via Cloud Download" that simulates anomalous M365/SharePoint downloads and USB exfiltration - Implemented automatic JSON replay handling for insider exfiltration scenario similar to MFA fatigue - Added client-side trace ID generator with UUID v4 format for better event correlation - Updated scenario mapping to include new insider threat scenario script
feat: add insider data exfiltration scenario and trace ID generation
Docker Compose no longer requires the version field and shows warnings when it's present. This removes the version: '3.8' line from both docker-compose.yml files to eliminate the deprecation warnings.
7ca9739 to
2f46f6f
Compare
|
Hi, just to let you know, I'm making also this change to my PR: #37 but I haven't heard back about it yet... |
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker Compose no longer requires the version field and shows warnings when it's present. This removes the
version: '3.8'line from both docker-compose.yml files to eliminate the deprecation warnings.Changes
version: '3.8'from rootdocker-compose.ymlversion: '3.8'fromBackend/docker-compose.ymlWhy
Modern Docker Compose versions automatically determine the appropriate compose file format and the version field is deprecated. This change eliminates the warning messages that appear when running docker-compose commands.