Fix NaN NoData handling in convolve_2d#474
Merged
phargogh merged 4 commits intonatcap:mainfrom Mar 13, 2026
Merged
Conversation
phargogh
approved these changes
Mar 13, 2026
Member
phargogh
left a comment
phargogh
left a comment
There was a problem hiding this comment.
Makes sense to me ... thanks @claire-simpson !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where, if a raster with
NoData=nanwas passed toconvolve_2d, a large part of/the entire resulting raster would becomenan.I followed #465 and opted to use
pygeoprocessing.array_equals_nodata(instead of addingequal_nan=Truetonumpy.isclose) to take advantage of the special case speedups that are handled in that helper function.Fixes #473