Update NatCap's name and website URL#459
Merged
dcdenu4 merged 2 commits intonatcap:mainfrom Feb 20, 2026
Merged
Conversation
Member
|
As I understand it, copyright notices like this are common, even conventional, in C++ header files. Even though it's not strictly necessary since ownership and copyright is established elsewhere in the repo, it shouldn't hurt anything by keeping it there as a comment and does make ownership a bit clearer if the file is copied out of this repo. I'd suggest we update that string, and probably the date as well. |
phargogh
requested changes
Feb 5, 2026
Member
phargogh
left a comment
phargogh
left a comment
There was a problem hiding this comment.
Thanks, Megan! These changes all look good to me, but could you update the license as well?
Contributor
Author
Member
|
Just waiting for the tests to pass before merging. Thanks @megannissel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458
This PR updates NatCap's name and website URL throughout the API docs, README, and pyproject.toml to reflect the Natural Capital Alliance name change.
This PR does not update
LICENSE.txt@phargogh One question that you may be able to answer:
src/pygeoprocessing/extensions/FastFileIterator.hincludes its own copyright line at the top of the file:Copyright 2019 The Natural Capital Project. I assume there was a historical reason for this, but should it still be there? And if so, should it get updated?