Move GDALUseExceptions and gdal_use_exceptions into new utils module#447
Merged
claire-simpson merged 4 commits intonatcap:mainfrom Sep 29, 2025
Merged
Move GDALUseExceptions and gdal_use_exceptions into new utils module#447claire-simpson merged 4 commits intonatcap:mainfrom
GDALUseExceptions and gdal_use_exceptions into new utils module#447claire-simpson merged 4 commits intonatcap:mainfrom
Conversation
claire-simpson
requested changes
Sep 29, 2025
Contributor
claire-simpson
left a comment
claire-simpson
left a comment
There was a problem hiding this comment.
Looks good! My only note is that test_pygeoprocessing.py still contains the line from pygeoprocessing.geoprocessing_core import gdal_use_exceptions
Member
Author
|
Thanks for catching that! Back to you |
claire-simpson
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #446
Moving these functions out of cython into a regular python module to prevent the issue described in #446. To avoid circular imports, I had to make a new module to contain them, which I named
utils.