Replace cython _ManagedRaster with shared C++ ManagedRaster implementation#443
Merged
phargogh merged 24 commits intonatcap:mainfrom Jul 16, 2025
Merged
Replace cython _ManagedRaster with shared C++ ManagedRaster implementation#443phargogh merged 24 commits intonatcap:mainfrom
phargogh merged 24 commits intonatcap:mainfrom
Conversation
emlys
commented
Jul 15, 2025
| # ghi | ||
| e = dem_array[row_index, col_index] | ||
| if _eq(e, dem_nodata): | ||
| if is_close(e, dem_nodata): |
Member
Author
There was a problem hiding this comment.
_eq did not allow for float imprecision, but it seems like it should have.
emlys
commented
Jul 15, 2025
| # on push, this is refs/heads/<branch name> | ||
| # on pull request, this is refs/pull/<pull request number>/merge | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
Member
Author
There was a problem hiding this comment.
Copied this over from natcap.invest. Keeps queued jobs from building up.
Member
Author
|
Sure! Added a history note |
phargogh
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439
pygeoprocessing.extensionswhich exposes the C++ extensionsManagedRaster,LRUCache,FastFileIterator, and associated utilitiesPYGEOPROCESSING_GDAL_LIB_PATH.ManagedRasterwith the new C++ implementationis_closeManagedRasters are closed using the.close()methodWhen these changes are released, we can remove the
ManagedRasterimplementation from natcap.invest and instead import it from pygeoprocessing.