Skip to content

Watershed delineation will now always create multipolygons#436

Merged
emlys merged 6 commits intonatcap:mainfrom
phargogh:bugfix/435-fix-watershed-layer-geom-type
Jul 10, 2025
Merged

Watershed delineation will now always create multipolygons#436
emlys merged 6 commits intonatcap:mainfrom
phargogh:bugfix/435-fix-watershed-layer-geom-type

Conversation

@phargogh
Copy link
Copy Markdown
Member

@phargogh phargogh commented Jul 9, 2025

Now, all geometries created by watershed_delineation will be of type ogr.wkbMultiPolygon. If any Polygon geometries are created, they are upgraded to MultiPolygon geometries.

I confirmed that this fixes natcap/invest#2067

Fixes #435

@phargogh phargogh requested a review from emlys July 9, 2025 23:55
Copy link
Copy Markdown
Member

@emlys emlys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@emlys emlys merged commit 0fe1efd into natcap:main Jul 10, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delineated watersheds have a geometry type of ogr.wkbUnknown Watersheds produced by DelineateIt can't be used in SDR

2 participants