Add an LRU Cache to the convolution worker#411
Draft
phargogh wants to merge 3 commits intonatcap:mainfrom
Draft
Conversation
…/373-add-lrucache-to-convolve2d Conflicts: HISTORY.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading pixel values during the convolution worker's execution allows us a bit of a speedup. On a ~3GB signal raster with a 200px-by-200px kernel raster, I'm seeing speedups of about 10%. There remain interesting opportunities for us to optimize further by more carefully considering spatial locality in scheduling of blocks for the worker.
Fixes #373