refactor: Modify playground to use vanilla JavaScript#2
Open
natanelia wants to merge 1 commit intofeat/add-react-playgroundfrom
Open
refactor: Modify playground to use vanilla JavaScript#2natanelia wants to merge 1 commit intofeat/add-react-playgroundfrom
natanelia wants to merge 1 commit intofeat/add-react-playgroundfrom
Conversation
This commit refactors the existing playground in `packages/playground` to use pure vanilla JavaScript, removing React and its associated dependencies. Changes include: - Removal of React, ReactDOM, and related type/plugin dependencies from `packages/playground/package.json`. - Deletion of React-specific files (`App.tsx`, `main.tsx`, `index.css`, `postcss.config.mjs`). - Recreation of `index.html` with a new structure suitable for a vanilla JS application. - Creation of `src/main.js` containing the client-side logic for interacting with `comlink-worker-pool`, managing UI elements, and displaying logs and stats without React. - Update of `vite.config.ts` to remove React plugin and ensure compatibility with a vanilla JS/TS Vite setup. - Confirmation that the existing GitHub deployment workflow (`deploy-playground.yml`) is still compatible with the vanilla JS Vite project. The playground now operates without React, directly using DOM manipulation for UI updates and `comlink-worker-pool` for managing worker threads.
Owner
Author
|
asdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the existing playground in
packages/playgroundto use pure vanilla JavaScript, removing React and its associated dependencies.Changes include:
packages/playground/package.json.App.tsx,main.tsx,index.css,postcss.config.mjs).index.htmlwith a new structure suitable for a vanilla JS application.src/main.jscontaining the client-side logic for interacting withcomlink-worker-pool, managing UI elements, and displaying logs and stats without React.vite.config.tsto remove React plugin and ensure compatibility with a vanilla JS/TS Vite setup.deploy-playground.yml) is still compatible with the vanilla JS Vite project.The playground now operates without React, directly using DOM manipulation for UI updates and
comlink-worker-poolfor managing worker threads.