fix: Fail fast if output directory is invalid or not writable #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the tool doesn't verify if the output directory exists or is writable before starting the concatenation process.
If you're processing a large batch of files, it's pretty frustrating to wait for the whole thing to run only to fail at the very last second because of a typo in the output path or a permission issue.
I added a quick check in
validate_output_pathto fail fast if the destination folder isn't there or isn't writable. Seems like a safer default.📚 Documentation preview 📚: https://stitchee--325.org.readthedocs.build/en/325/