Open Source Draco Release #62
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add add-to-project.yml Workflow
The SBN app is failing to compile because it includes a file cfe_sb_events.h that no longer exists. This file was renamed to cfe_sb_eventids.h in cfe in 941468d5696a2156e8d2c718930db1e72d1a7cd4. This commit modifies the include to use the file's new name.
The SBN app's coverage tests are failing to compile because they include a file cfe_sb_events.h that no longer exists. This file was renamed to cfe_sb_eventids.h in 941468d5696a2156e8d2c718930db1e72d1a7cd4. This commit modifies the include to that file's new name.
The name of the public interface of the cfe-core library was changed to core_api in cFE. This commit adjusts the CMakeLists.txt files for SBN's unit tests and the UDP module's unit tests accordingly.
It is not necessary for applications to register themselves, this is all done automatically in newer versions of CFE. The same applies to child task registration. This commit removes the tests for the main app's registration, and for the childt ask registration when sending and receiving.
The coverage tests make use of the type CFE_EVS_LongEventTlm_t, but they fail to import cfe_evs_msg.h, where it is defined. This makes the tests fail to compile. This commit adds the necessary import to SBN's coverage tests.
The type of CFE_SB_MsgId_t has changed in new versions of CFE, from a plain int32 to a value wrapped inside a struct. This commit adjusts the tests for SBN's coverage tests and the UDP module to wrap/unwrap CFE_SB_MsgId_t values accordingly.
The SpacecraftID is required as an argument for functions that send and receive data from peers or from the network in SBN. This commit adjusts tests accordingly.
The CMakeLists.txt files are missing dependencies to libraries in the cFS ecosystem, preventing the tests from compiling. This commit adds multiple link dependencies as needed for the compilation to complete for the main application and the UDP protocol module. It also removes an incorrect dependency on osconfig.h.
Fix cFS/cFS#12, Add PR to Project
…d-to-project-workflow Part cFS/workflows#39, Exclude Draft PRs for Add to Project Workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO