Conversation
| 'bin/dswx_compare.py'], | ||
| install_requires=['argparse', 'numpy', 'yamale', | ||
| 'osgeo', 'scipy', 'pytest', 'requests'], | ||
| 'scipy', 'pytest', 'requests'], |
There was a problem hiding this comment.
osgeo contains access to gdal, which is a necessary dependency for PROTEUS.
If this dependency is removed, and then a user tries to install and run PROTEUS in a fresh conda environment, then it will fail due to the missing dependency.
If this fix worked on your system and you were still able to run PROTEUS, by chance, were you working in an existing conda environment, where osgeo / gdal were previously installed for a different application?
There was a problem hiding this comment.
osgeocontains access togdal, which is a necessary dependency for PROTEUS.If this dependency is removed, and then a user tries to install and run PROTEUS in a fresh conda environment, then it will fail due to the missing dependency.
If this fix worked on your system and you were still able to run PROTEUS, by chance, were you working in an existing conda environment, where
osgeo/gdalwere previously installed for a different application?
osgeo is not the proper name for the library listed on PyPI from what I have read and tried locally e.g. https://pypi.org/project/osgeo/
Not negating from osgeo import gdal just highlighting the package name should be updated in setup.py as it is here too: https://github.com/nasa/PROTEUS/blob/main/docker/requirements.txt#L1
There was a problem hiding this comment.
I tried adding gdal but now it's not passing CircleCI - I will let you figure out how to fix this or maybe it's not necessary.
There was a problem hiding this comment.
That doesn't surprise me that it failed. Please see this comment: #51 (comment)
Updating PROTEUS to be installed via pip and not setup.py would likely be considered a new feature development.
2 participants
Resolves #51