Skip to content

Conversation

@euaaaio
Copy link
Member

@euaaaio euaaaio commented Aug 6, 2024

No description provided.

@janhendry
Copy link

Hey I wanted to ask if there is an effort to merge this merge request or are there any concerns. I would be very happy about the feature when it comes back:D

@euaaaio
Copy link
Member Author

euaaaio commented Nov 27, 2024

Hey I wanted to ask if there is an effort to merge this merge request or are there any concerns. I would be very happy about the feature when it comes back:D

Unfortunately, I don’t have a good project at hand to test it. @janhendry, can I ask you help me with testing this implementation? 😅

@euaaaio euaaaio requested a review from Copilot April 18, 2025 22:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for an actions API to the Nano Stores logger and related modules. Key changes include updates to the creation and logging of actions, adjustments in tests to verify action behaviors, and corresponding documentation updates.

Reviewed Changes

Copilot reviewed 18 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/index.ts Adds the 'action' type to the badge regex for consistent action support.
printer/index.js Introduces a new badge style for actions.
logger/types.ts Updates the import path for the logger module.
logger/index.test.ts Uncomments and activates action functions in tests.
logger/index.js Integrates action logging into the logger with start, error, and end hooks.
logger/errors.ts Demonstrates type failures for incorrect configuration of ignoreActions and mount options.
index.js Exports the actions API.
demo/index.ts Revises demo code to leverage the new actions API.
creator-logger/* Incorporates actions into creator logger configuration and tests.
build-logger/index.js Refactors logger builder to handle actions and ignore specific actions.
action/index.js Introduces the actions API implementation.
README.md Updates documentation to reflect the new action logging features.
.github/workflows/test.yml Updates workflow permissions.
Files not reviewed (4)
  • creator-logger/snapshots/index.test.ts.snap: Language not supported
  • logger/snapshots/index.test.ts.snap: Language not supported
  • package.json: Language not supported
  • pnpm-lock.yaml: Language not supported

@euaaaio euaaaio changed the base branch from main to next April 18, 2025 22:10
@euaaaio euaaaio merged commit ad20943 into next Apr 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants