ci: add support for PHP 8.4 in workflows and installer #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanasess
force-pushed
the
improve/php8.4
branch
from
6e873f8 to
d79ecf7
Compare
nanasess
force-pushed
the
improve/php8.4
branch
from
d79ecf7 to
51d9292
Compare
The dist/index.js file was out of sync with the source code changes that added PHP 8.4 support. The source code correctly included 8.4 in the APT version check (<= 8.4), but the distributed bundle still had the old version check (<= 8.3), causing PHP 8.4 to fall back to phpenv installation instead of using APT. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for PHP 8.4 throughout the codebase, ensuring that the workflow, installer logic, and tests all recognize and handle this new version. The most important changes are:
Resolves #316
CI Workflow Updates:
.github/workflows/workflow.yml, so all jobs are now run against this version.Installer Logic:
convertInstallVersioninsrc/installer.tsto recognize '8.4' and convert it to '8.4.0'.Testing:
__tests__/run.test.tsto verify thathasAptVersioncorrectly recognizes PHP 8.4 as available.