Skip to content

Conversation

@ramseycoder
Copy link
Collaborator

make a quiz page

@linear
Copy link

linear bot commented Oct 26, 2021

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 26, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f578815
Status: ✅  Deploy successful!
Preview URL: https://2128c247.platform-nan-dev-8sl.pages.dev

View logs

@ramseycoder ramseycoder marked this pull request as ready for review October 26, 2021 14:16
class={`mli ${link ? 'link' : ''}`}
onClick={(e) => {
if (link) navigate(link)
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meme commentaire niveau du lien ici

css(`
.question_card {
padding: 2ch;
border: 2px dashed var(--comment-darker);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peu etre utiliser l'outline plutot que la border pour eviter de decaller le design ?

width:100%;
height: 100%;
top:0;
cursor:pointer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on garde pointer pour les liens

align-items:center;
justify-content:flex-start;
margin: 1ch auto;
cursor:pointer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on garde pointer pour les liens, pointer ca veut dire que ca pointe quelque part, ca indique une navigation

Copy link
Member

@kigiri kigiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il semble que cette PR n'est pas bien baser, pourquoi affecte t'elle l'exercise ?

page/quiz.jsx Outdated
> Time Remaining : <Span bg="selection">[05:25]</Span>
</P>
<P>
Answered : <Span bg="selection" fg="comment-lighter">[14/20]</Span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'suis pas super fan de voir des valeurs en dur comme ca [14/20] pourquoi pas calculer la vrais valeur ?

page/quiz.jsx Outdated
<Div class="options">
<P>
{' '}
> Time Remaining : <Span bg="selection">[05:25]</Span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y aura du temps ?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui il y'a du temps, l'étudiant ne peut avoir un temps indéfini pour fait le quiz , au quel cas , il trouvera toutes les réponses ..., et ça n'aurait plus l'air a forme d'un quiz..
Normalement un quiz est sensé se déroulé dans un temps bien précis.

@ramseycoder ramseycoder force-pushed the ramsey/nan-16-page-de-quiz branch from cb9dc73 to f578815 Compare November 2, 2021 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants