Parse markdown and generate JSON file for exercises #94
Conversation
Deploying with
|
| Latest commit: |
0842a27
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fce05f6a.platform-nan-dev-8sl.pages.dev |
kigiri
left a comment
kigiri
left a comment
There was a problem hiding this comment.
ya encore d'autres trucs a review je pense mais tu peu deja avancer sur les points que j'ai mis en avant la
dev/exo-parser.js
Outdated
| const isH2 = (node) => node.type === 'heading' && node.depth === 2 | ||
| const isH3 = (node) => node.type === 'heading' && node.depth === 3 | ||
| const text = (node) => node.type === 'paragraph' | ||
| const isList = (node) => node.type === 'list' |
There was a problem hiding this comment.
I don't think text is a good name to check if something is a paragraph. I you want to keep it short call it isP and isList could be isLI so it's like HTML tags
just text give me the impression that it will return the text of the node
dev/exo-parser.js
Outdated
| return content | ||
| } | ||
|
|
||
| const dirList = await readdir('js-introduction') |
There was a problem hiding this comment.
the name of the directory should be defined by the build.js file, not hard coded here
dev/exo-parser.js
Outdated
| .flatMap((e) => e.children) | ||
| .flatMap((v) => v.children) | ||
| .map((k) => k.value) | ||
| content.notions = ul |
There was a problem hiding this comment.
fait plutot:
content.notions = children(node).map(getTrimValue).filter(Boolean)
dev/exo-parser.js
Outdated
| } else if (mode === 'instructions') { | ||
| if (text(node)) { | ||
| let p = node.children.map((e) => e.value) | ||
| content.instructions = p.join('') |
There was a problem hiding this comment.
On veut garder la structure, juste stock toute la node, pas besoin de faire un cas special.
Comme ca on pourra render tout les element en (p)react
| } | ||
| } else if (mode) { | ||
| // any other mode is stored in raw tree | ||
| content[mode].push(node) |
There was a problem hiding this comment.
## Instructions pourra etre gerer ici
dev/exo-parser.js
Outdated
| content[mode].push(node) | ||
| } else { | ||
| // before any mode is set, we are writing the description | ||
| content.description += textContent(node) |
There was a problem hiding this comment.
ca vaut ptet le coup de rajouter un \n quand on concatene ici:
content.description += `${textContent(node).trim()}\n`
dev/exo-parser.js
Outdated
| await rename( | ||
| join(fileURLToPath(dirname(import.meta.url)), `../${file}`), | ||
| join(fileURLToPath(dirname(import.meta.url)), `../exoBundle/${file}`), | ||
| ) |
There was a problem hiding this comment.
ca serais bien d'avoir:
const rootDir = fileURLToPath(dirname(import.meta.url))plutot que de le repeter a chaque fois
dev/exo-parser.js
Outdated
| }) | ||
|
|
||
| const rootFile = await ( | ||
| await readdir('./') |
There was a problem hiding this comment.
la t'utilise un chemin relatif, ton script va pas faire la meme chose en fonction du cwd, ou tu le run, c'est mieu de ce baser sur la position du fichier la avec fileURLToPath(dirname(import.meta.url)) comme tu l'a fait ailleur
dev/exo-parser.js
Outdated
|
|
||
| export const generateExoFile = async () => { | ||
| dirList.map(async (filename) => { | ||
| const data = Object.fromEntries(entries)[`${filename}`] |
dev/server.js
Outdated
| sendResponse({ body, options, res }) | ||
| }).listen(PORT, () => console.log(`Dev server ready on ${process.env.DOMAIN}`)) | ||
| }).listen(PORT, async () => { | ||
| await generateExoFile() |
There was a problem hiding this comment.
il faudrais generer avant ca, et aussi s'assurer que les fichier sont accessible a fetch
dev/exo-parser.js
Outdated
|
|
||
| const moveFile = async (file) => | ||
| await rename(join(rootDir, file), join(rootDir, 'exoBundle', file)) | ||
| await rename(join(rootDir, file), join(rootDir, 'exobundle', file)) |
There was a problem hiding this comment.
pas besoin d'async / await la:
const moveFile = (file) =>
rename(join(rootDir, file), join(rootDir, 'exobundle', file))
dev/exo-parser.js
Outdated
| await (await readdir(rootDir)) | ||
| .filter((file) => file.includes('exercise.json')) | ||
| .map(moveFile) | ||
| return await Promise.all( |
There was a problem hiding this comment.
pas besoin d'await quand tu return non plus
dev/server.js
Outdated
|
|
||
| // generate bundle for js-introduction exercise | ||
| await getJsonExoFile() | ||
| await generateJSONExo() |
There was a problem hiding this comment.
j'avais fais des commentaires a ce niveau, le generate doit etre fait pas build.js, non pas par le server.js
There was a problem hiding this comment.
J'ai completement omis de l'enlever je le faisais pour des tests locaux
Parse markdown and generate JSON file for exercises