Allow wildcards for query string parameters#81
Open
KyleW wants to merge 4 commits intonamshi:masterfrom
Open
Conversation
KyleW
commented
Nov 8, 2019
Comment on lines
+250
to
+253
| if (body && query) { | ||
| return '_'+ body + '--' + query; | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
I'd appreciate another set of eyes on this.
This is the behavior described in the docs, but I don't think it was actually implemented before now. I added what I think is the right implementation, but I don't want to inadvertently introduce a breaking change.
If it's in doubt, I'm glad to remove it since it's not directly tied to the core purpose of the pr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #67 . Allow
__in file names in place of a query param. For example:GET--foo=bar&buz=__.mockmatchesGET /?foo=bar&buz=bazOther changes in this PR: