backend/enhancement: Integrating async api for pan and gst #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brajmohank1
force-pushed
the
integrating-async-api-for-pan-gst
branch
from
76f1861 to
48271fa
Compare
| (Nothing, Just pan, Nothing, Nothing) -> pure (PanResult (Output (Just pan) Nothing)) | ||
| (Nothing, Nothing, Just gst, Nothing) -> pure (GstResult (Output (Just gst) Nothing)) | ||
| (Nothing, Nothing, Nothing, Just rc) -> pure (RCResult (Output Nothing (Just rc))) | ||
| _ -> fail "Unable to decode IdfyResult" |
Contributor
There was a problem hiding this comment.
I think final parsing can fail here, because three values of this tuple mDL, mPan, mGst potentially can be Just
For example this one
mPan :: PanVerificationOutput <- o .:? "source_output"
PanVerificationOutput data type have only optional fields and even empty object will be parsed as Just pan
Maybe there is other way how we can differentiate between these three cases?
Brajmohank1
force-pushed
the
integrating-async-api-for-pan-gst
branch
3 times, most recently
from
bf3d342 to
baa4039
Compare
Brajmohank1
force-pushed
the
integrating-async-api-for-pan-gst
branch
from
5bdadb3 to
f7ad416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
./dev/format-all-files.sh