backend/feat/split_settlement #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
f13199e to
6ab20d6
Compare
Member
|
Could you update this PR with latest commits from |
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
f197b13 to
15af26d
Compare
hkmangla
approved these changes
Oct 1, 2024
|
|
||
| data SplitSettlementResponse = SplitSettlementResponse | ||
| { splitDetails :: [SplitDetailsResponse], | ||
| splitApplied :: Bool |
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
e7c6140 to
e20fe05
Compare
hkmangla
previously requested changes
Oct 1, 2024
lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs
Outdated
Show resolved
Hide resolved
lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Common.hs
Outdated
Show resolved
Hide resolved
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
e20fe05 to
0f3aa41
Compare
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
0f3aa41 to
33a7e43
Compare
khuzema786
approved these changes
Oct 18, 2024
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
33a7e43 to
9fe43dc
Compare
khuzema786
approved these changes
Nov 16, 2024
khuzema786
reviewed
Nov 16, 2024
| ("merchant_id", toQueryParam merchantId), | ||
| ("format", toQueryParam format) | ||
| ("format", toQueryParam format), | ||
| ("order.metadata.split_settlement_details", toQueryParam (splitSettlementDetails order)) |
Contributor
There was a problem hiding this comment.
If splitSettlementDetails is Nothing, this field will still go, we can prevent it from being sent ?
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
9fe43dc to
4988509
Compare
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
4988509 to
617bc31
Compare
khuzema786
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
./dev/format-all-files.sh