Skip to content

fix: debug runPostCheck OSRM case #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TejaswiniT167 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: debug runPostCheck OSRM case #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/mobility-core/src/Kernel/External/Maps/Interface.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,22 @@ runPostCheck mapsService req res = do
case mapsService of
Google -> return (everySnippetIs (< snippetThreshold) res.snappedPoints)
MMI -> return (everySnippetIs (< snippetThreshold) res.snappedPoints)
OSRM -> return $ (< osrmThreshold) $ distanceBetweenInMeters (last req.points) (last res.snappedPoints)
OSRM ->
case (req.points, res.snappedPoints) of
(_x : _xs, _y : _ys) -> return $ (< osrmThreshold) $ distanceBetweenInMeters (last req.points) (last res.snappedPoints)
(_, _) -> reportEmptyPoints req res
_ -> return True
where
reportEmptyPoints SnapToRoadReq {points} SnapToRoadResp {snappedPoints} = do
let reqPointsCount = length points
resPointsCount = length snappedPoints
logTagError "DebugErrorLog: SnapToRoadPostCheck" $
"OSRM post-check skipped due to empty points. "
<> "reqPointsCount="
<> show reqPointsCount
<> ", resPointsCount="
<> show resPointsCount
return False

snapToRoadWithFallback ::
( EncFlow m r,
Expand Down