Skip to content

Mobility GHC927 rebased packet-set upgrade#13

Closed
arjunkathuria wants to merge 6 commits intonammayatri:mainfrom
arjunkathuria:Mobility-GHC927-Rebased
Closed

Mobility GHC927 rebased packet-set upgrade#13
arjunkathuria wants to merge 6 commits intonammayatri:mainfrom
arjunkathuria:Mobility-GHC927-Rebased

Conversation

@arjunkathuria
Copy link
Contributor

supersedes #6

This PR contains GHC-9.2.7 package set updates (same as #5 , #8), rebased for updated haskell-flake changes, minus the ormolu changes in #10

@srid srid self-requested a review June 9, 2023 15:29
* Adds the custom package set for GHC-9.2.7

* This tracks specifically the `ghc927` haskell nix packages set.

* This package set is meant to be used with the nammayatri set of projects.
  making ghc-9.2.7 and the accompanying package set the default
  going forward.

* This is meant to upgrade the previous ghc810 package stack.
* Adds a comment w.r.t to the package-set version choice.

* This was requested as a PR feedback, found here:-
  nammayatri#5 (comment)
…in nix/haskell/default.nix

* Makes the newly added GHC-9.2.7 the default `basePackages` set
  in nix/haskell/default.nix file

* This commit replaces the old gch810 set with the new ghc927 set.
* Replaces the old ghc810 artifacts and references in the codebase
  with the newer ghc927 ones, effectively replacing them.

* "flake.nix" now exports `ghc927` instead of `ghc810` fields/attribute
  in flakeModules.

* The older ghc810 references have been commented out across the codebase,
  to be deprecated and removed in the future.
* Adds GHC-9.2.7 package set reference in `what's provided` section

* Updates readme with 810 deprecation note
* Migrates the ghc-927 package set to work with the new
  updated haskell-flake 0.4.0 syntax

* Deletes a now-redundant function in the ghc-927 package-set file
@arjunkathuria arjunkathuria force-pushed the Mobility-GHC927-Rebased branch from 943e7aa to 3a12f08 Compare June 16, 2023 09:22
@arjunkathuria
Copy link
Contributor Author

^note:- rebased again - 16/06/23

rebased again - newest nammayatri commits failed to build without newer changes in the common repo.

@srid
Copy link
Member

srid commented Jun 16, 2023

@arjunkathuria When will GHC 9 support be merged to main in ny repos? What's left to do?

Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Squash merge this in sync with the other PRs, once they too are approved.

@srid
Copy link
Member

srid commented Dec 28, 2023

Closing since #18 was merged.

@srid srid closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants