Remove :2eDS_Store and Added All Eternals Deck#2
Open
mianong wants to merge 4 commits intonall:masterfrom
Open
Remove :2eDS_Store and Added All Eternals Deck#2mianong wants to merge 4 commits intonall:masterfrom
mianong wants to merge 4 commits intonall:masterfrom
Conversation
I think I've made all the required changes. I dont quite understand the role of the constants file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will remove the :2eDS_Store file and fix the issue that non-Mac users have with the file.
Also, I added All Eternals Deck, trying to follow the conventions. (to be honest I made these changes over four years ago and I don't remember testing these changes but I think they would work).
This should resolve issue #1
Let me know if this works.
Thanks,
Max