Add option to show single progress bar for all workers#239
Add option to show single progress bar for all workers#239lpuglia wants to merge 9 commits intonalepae:masterfrom
Conversation
added type to single_bar argument
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 91.37% 90.55% -0.83%
==========================================
Files 12 12
Lines 580 593 +13
==========================================
+ Hits 530 537 +7
- Misses 50 56 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added type
added fixture for single_bar
fixed name
|
@till-m should I add tests for codecov? |
|
The uncovered lines seem to only relate to the use in notebooks, I don't know any convenient way to test them. If you have something, feel free to let me know. I will try to test them manually by tomorrow so that I can merge this with no further delay. |
till-m
left a comment
till-m
left a comment
There was a problem hiding this comment.
Hi @lpuglia,
I tested it, and it works, so the PR looks good in general to me.
Two small changes:
I think the code should either use single_bar or single_progress_bar, not both. And I would also ask you to briefly document the functionality in the user guide.
|
@till-m done. By the way, it looks fine in both ipywidget |
| if use_memory_fs | ||
| else parallelize_with_pipe | ||
| ) | ||
| parallelize = partial(parallelize, single_bar=single_bar) |
There was a problem hiding this comment.
IMO instead it would be better to supply the argument in lines 528 onward as it is currently done with the arguments of parallelize. @nalepae any opinion?
|
This is feature is so important that this PR almost brought a tear in my eyes |
|
@nalepae can you approve? |
4 participants
Not sure why ApolloBian didn't reply further to the PR(#203) but i'm here to make sure this change is merged.