testing / fixing issue 32 #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the tests have been using an installed sickle version, which was in PATH, not the built ones
- I added these tests just out of curiosity to try to integrate valgrind into the test suite - also fixes the only detected leaks which are rather trivial and would have been non-problematic anyway (just to make the tests pass)
... this should be done by the devs to assure configure will check everything
- the included, outdated kseq.h is removed - instead configure checks for htslib via pkg-config - htslib includes the latest version of kseq.h, latest htslib is 1.2.1 as of this writing - the __KS* and __KSEQ* imports have changed a bit, they are modified to work with the latest kseq.h/htslib version without throwing compiler warnings
Author
|
The latest commits now fix #32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a test for #32