Skip to content

addcoin: specify remote nodes when adding coins #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nahuhh merged 1 commit into from
Jun 27, 2025
Merged

addcoin: specify remote nodes when adding coins #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 69 additions & 4 deletions bsx/addcoin.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,75 @@ if [[ -z $addcoin ]]; then
read -p 'Full name of coin to add [example: litecoin] ' addcoin
fi

## Confirm
read -p $'\nAdd '$addcoin' to your BasicSwap install, correct? Press ENTER to continue. CTRL-C to exit'
## Set wallet name
ticker="${coin_map[$addcoin]}"
wallet_env="${ticker}_WALLET_NAME"
wallet_name="BSX_${ticker}"

# TODO need to test descriptor wallet, mweb, and coins that need reseeding. excluding for now
# bitcoincash doesnt like multiwallet
local_only=(namecoin litecoin pivx bitcoincash)
# coins with separate wallet daemons
wallet_daemon_coins=(monero wownero decred)

manage_daemon_false() {
jq ".chainclients.${addcoin}.manage_daemon = false" \
$SWAP_DATADIR/basicswap.json > basicswap.tmp && mv basicswap.tmp $SWAP_DATADIR/basicswap.json
}

## Remote node
if [[ ! "${local_only[@]}" =~ "${addcoin}" ]]; then
read -p "Connecting to an external ${ticker} node (core node, NOT electrum)? [y/N]: " remote_node
if [[ "${remote_node}" =~ ^[yY]$ ]]; then
existing_config=$(jq .chainclients."${addcoin}" $SWAP_DATADIR/basicswap.json)
# only set ip, port, login, and wallet name if first time adding coin
if [[ "${existing_config}" = null ]]; then
if [[ "decred" != "${addcoin}" ]]; then
export "${wallet_env}"="${wallet_name}"
fi

red "\nNote: YMMV! Only proceed if you know what you are doing, and if your node has been configured to accept connections!\n"
red "\nNote: This MAY not work for all coins.\n"
red "\nWarning: Wallet files may be stored in the datadir of the external node.\n"
read -p $'\nProceed to add '"${ticker}"$' to your BasicSwap install? Press ENTER to continue. CTRL-C to exit\n'
until [[ $confirm_node =~ ^[yY]$ ]]; do
read -p "Enter your node's IP address: " node_ip
read -p "Enter your node's RPC port: " node_port
green "Is this the correct RPC address and port: ${node_ip}:${node_port}? [y/N]:\n"
read -p "" confirm_node
done
rpc_host="${ticker}_RPC_HOST"
rpc_port="${ticker}_RPC_PORT"
export "${rpc_host}"="${node_ip}"
export "${rpc_port}"="${node_port}"

# only xmr-type coins have optional rpcauth
if [[ "${wallet_daemon_coins[@]}" =~ "${addcoin}" ]]; then
read -p "Is the ${ticker} daemon password protected? [y/N]" xmr_pass
fi

if [[ "${xmr_pass}" =~ ^[yY]$ ]] || [[ ! "${wallet_daemon_coins[@]}" =~ "${addcoin}" ]]; then
until [[ "${node_pass}" ]] && [[ "${node_pass}" = "${node_pass2}" ]]; do
read -p "Enter the RPC username of your ${ticker} daemon: " node_user
read -sp "Enter the RPC password of ${ticker} daemon: " node_pass
echo
read -sp "Re-enter the RPC password of ${ticker} daemon: " node_pass2
if [[ "${node_pass}" != "${node_pass2}" ]]; then
red "Passwords dont match. Try again\n"
fi
done
rpc_user="${ticker}_RPC_USER"
rpc_pass="${ticker}_RPC_PWD"
export "${rpc_user}"="${node_user}"
export "${rpc_pass}"="${node_pass}"
fi
fi
fi
fi

## Add the coin
fastsync=""
if [ $addcoin = bitcoin ]; then

if [[ ! "${remote_node}" =~ ^[yY]$ ]] && [[ "${addcoin}" = bitcoin ]]; then
read -p 'Use --usebtcfastsync for bitcoin? [Y/n] ' btcfastsync
if [[ "${btcfastsync}" =~ ^[nN]$ ]]; then
echo "Not using btcfastsync"
Expand All @@ -22,4 +84,7 @@ if [ $addcoin = bitcoin ]; then
fastsync="--usebtcfastsync"
fi
fi

basicswap-prepare --datadir=$SWAP_DATADIR --addcoin=$addcoin ${fastsync:+$fastsync}
# if re-enabling coin that is using a remote daemon, disable "manage_daemon"
[[ "${remote_node}" =~ ^[yY]$ ]] && [[ -z "${node_ip}" ]] && manage_daemon_false
16 changes: 16 additions & 0 deletions bsx/shared.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,22 @@ coins=$(
EOF
)

# Coin map
declare -A coin_map
coin_map=(
[bitcoin]="BTC"
[bitcoincash]="BCH"
[dash]="DASH"
[decred]="DCR"
[dogecoin]="DOGE"
[firo]="FIRO"
[litecoin]="LTC"
[monero]="XMR"
[namecoin]="NMC"
[pivx]="PIVX"
[wownero]="WOW"
)

# Activate venv
activate_venv() {
source $SWAP_DATADIR/venv/bin/activate
Expand Down