Conversation
Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
…ests Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
nahcnuj
left a comment
There was a problem hiding this comment.
以下の観点でE2Eテストを追加してください。
- バッジの部分をクリックしたら番組視聴ページへ遷移する
- それ以外の部分をクリックしたらランディングページへ遷移する
Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
Added in 67c6b6f as
|
|
@copilot |
Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
|
@copilot |
Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
|
@copilot |
…ss group Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
Fixed in a9e6423. Root cause: Fix: spawn with |
|
@copilot |
…lick_makamujo_landing) Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
Done in ce7108e. Here's what was added:
|
…ts are fired Co-authored-by: nahcnuj <2093896+nahcnuj@users.noreply.github.com>
Done in c95903c.
|
Add the Makamujo AI-VTuber project banner (
https://www.nahcnuj.work/makamujo/banner.png) across the site with two distinct clickable zones using an HTML image map.New component:
MakamujoBanner105,67,306,87within the 320×100px image) →https://live.nicovideo.jp/watch/user/14171889https://www.nahcnuj.work/makamujo/index.htmlPlacements
routes/index.tsx) — before<LinkRow>diary,works,essays) — after<h1>(banner included directly in route content)Article.tsx) — rendered before the optional<h2>他の記事</h2>section, but not on sub-index pages (/index.html) since those already include the banner in their own contentGoogle Analytics event tracking
Clicking either banner area fires a GA4 event before navigation:
click_makamujo_nicovideoclick_makamujo_landingNavigation is delayed until the GA beacon is confirmed sent, or at most 500 ms, whichever comes first. Implemented in
app/lib/makamujoBannerTracker.tsusing the same injectable-dependency pattern assetupAdControl/setupScrollDepthTracking, and wired up inapp/client.ts.Tests
Added
tests/e2e/makamujo-banner.test.tswith Playwright E2E click-navigation tests:105,67,306,87) in a real Chromium browser, asserts navigation tohttps://live.nicovideo.jp/watch/user/14171889, and asserts theclick_makamujo_nicovideoGA event was firedhttps://www.nahcnuj.work/makamujo/index.html, and asserts theclick_makamujo_landingGA event was firedThe tests start the Vite dev server, open a real Chromium browser, navigate to the home page, click at exact image coordinates, intercept the outgoing navigation request to assert the correct target URL, and capture the dev-mode
console.log('[gtag]', ...)output to assert the correct GA event name — all without loading third-party sites.Added
app/lib/makamujoBannerTracker.test.tswith 13 unit tests covering correct event names,event_callback-driven navigation, 500 ms timeout fallback, no-double-navigation,preventDefaultcall, and edge cases.Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.