Removed duplicate property definitions in CityLearnEnv class#155
Open
LucasNH wants to merge 1 commit intonagyzoltan:masterfrom
Open
Removed duplicate property definitions in CityLearnEnv class#155LucasNH wants to merge 1 commit intonagyzoltan:masterfrom
LucasNH wants to merge 1 commit intonagyzoltan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed duplicate property definitions in CityLearnEnv class, removed trailing whitespace.
Issue
Duplicate definitions of the following properties in the CityLearnEnv class:
Original definitions in lines 629-654, duplicate definitions in lines 656-681.
(base) ~ % sed -n '628,682p' citylearn/citylearn.py | grep 'def ' | sort | uniq -d def net_electricity_consumption_cost_without_storage(self) -> np.ndarray: def net_electricity_consumption_emission_without_storage(self) -> np.ndarray: def net_electricity_consumption_without_storage(self) -> np.ndarray:Changes
Screenshots
n/a
Checklist
requirements.txtfile, if applicable.Additional notes
The only functional changes were made within lines 628 and 682 by removed duplicate property definitions in CityLearnEnv class of citylearn/citylearn.py. All other changes are trailing whitespace removal.