Removed bad make recipe dependency #99
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running OSX (15.5) and was getting this error during build:
Linking ELF file: build/us/levels/bbh/leveldata.o -> build/us/levels/bbh/leveldata.elf
mips64-elf-ld: build/us/levels/bbh/leveldata.o:(.data+0x6af4): undefined reference to
spooky_09008800' mips64-elf-ld: build/us/levels/bbh/leveldata.o:(.data+0x6dfc): undefined reference tospooky_09004800'mips64-elf-ld: build/us/levels/bbh/leveldata.o:(.data+0x6e8c): undefined reference to
spooky_0900A000' mips64-elf-ld: build/us/levels/bbh/leveldata.o:(.data+0x6ee4): undefined reference tospooky_09003800'...
I resolved the issue by removing a dependency in the relevant recipe. I think there is some issue with the resolution of TEXTURE_BIN when evaluating the recipe.
I don't think that second dependency is ever actually needed in the recipe header (although it is used in the build command). Whenever we build a leveldata.elf file, we are just assuming that
$(TEXTURE_BIN).elfexists. If$(TEXTURE_BIN).elfdoesn't exist, you'll get an error regardless of whether it is included in the recipe header.There might be a better solution here, but this is the best I could find