Add support for HTTPRoute resource in the Helm Chart #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanio
added
priority/normal
There was a problem hiding this comment.
Pull request overview
This PR adds support for Kubernetes Gateway API's HTTPRoute resource to the dashboard Helm chart, enabling migration from traditional Ingress resources to Gateway APIs. The implementation includes configuration options in values.yaml, a new template for the HTTPRoute resource, and corresponding documentation updates.
Key Changes:
- Added HTTPRoute configuration section to values.yaml with fields for parent Gateway references, hostnames, and resource metadata
- Created http-route.yaml template to generate HTTPRoute resources when enabled
- Updated README.md with documentation for the new HTTPRoute configuration options
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| charts/dashboard/values.yaml | Adds httpRoute configuration block with create flag, parentRefs, hostnames, annotations, and labels fields |
| charts/dashboard/templates/http-route.yaml | New template that generates HTTPRoute resource with Gateway references and routing rules |
| charts/dashboard/README.md | Documents the new httpRoute configuration parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
As part of the general migration of Ingress to Gateway APIs, add support for creating an HTTPRoute resource which will attach this service to a Gateway API, if deployed and configured.
jonathanio
force-pushed
the
add-http-route-support-in-helm
branch
from
3f43bb3 to
c28a04f
Compare
Skip some checks on logger linting issues relating to the use of slog.Group within the logger, which is a single item rather than a pair.
jonathanio
force-pushed
the
add-http-route-support-in-helm
branch
from
25878ee to
0a5ad4e
Compare
The path for the ARM64 builds on both Linux and macOS have been updated, so fix the GitHub Actions which upload these files to ensure the build passes.
jonathanio
force-pushed
the
add-http-route-support-in-helm
branch
from
89f79f2 to
40bee10
Compare
Add the 1.24 and 1.25 Go releases for testing builds before migration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the general migration of
Ingressto Gateway APIs, add support for creating anHTTPRouteresource which will attach this service to a Gateway API, if deployed and configured.Checklist
Before raising or requesting a review of the pull request, please check and confirm the following items have been performed, where possible:
release/...,type/..., andchanges/...labels, as needed, to this pull request