Skip to content

Bump ZeroMQ and fix some Buffer deprecations #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mauricioszabo wants to merge 5 commits into
base: zeromq6
Choose a base branch
from
Open

Bump ZeroMQ and fix some Buffer deprecations #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c21d618
Fixed Buffer deprecations
mauricioszabo Feb 12, 2024
9265465
Bump ZeroMQ
mauricioszabo Feb 12, 2024
4a474a7
Adding a lockfile
mauricioszabo Feb 12, 2024
3ed58ed
Remove lockfile
mauricioszabo Aug 5, 2024
d5b0117
Added Maurício to AUTHORS file.
mauricioszabo Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ Kevin Kwok <kkwok@mit.edu>
Min RK <benjaminrk@gmail.com>
Nicolas Riesco <enquiries@nicolasriesco.net>
Will Whitney <wfwhitney@gmail.com>
Maurício Szabo <mauricio.szabo@gmail.com>
10 changes: 5 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,10 @@ Message.prototype._encode = function(scheme, key) {
if (key) {
var hmac = crypto.createHmac(scheme, key);
var encoding = "utf8";
hmac.update(new Buffer(header, encoding));
hmac.update(new Buffer(parent_header, encoding));
hmac.update(new Buffer(metadata, encoding));
hmac.update(new Buffer(content, encoding));
hmac.update(new Buffer.from(header, encoding));
hmac.update(new Buffer.from(parent_header, encoding));
hmac.update(new Buffer.from(metadata, encoding));
hmac.update(new Buffer.from(content, encoding));
signature = hmac.digest("hex");
}

Expand Down Expand Up @@ -451,4 +451,4 @@ module.exports = {
* ZeroMQ bindings
*/
zmq: zmq,
};
};
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"deasync": "0.1",
"uuid": "3",
"zeromq": "6.0.0-beta.6"
"zeromq": "6.0.0-beta.19"
},
"engines": {
"node": ">=10.12"
Expand Down
6 changes: 3 additions & 3 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ describe("Listeners", function() {
// Assign identity to client socket (only for testing purposes)
context.clientSocket.setsockopt(
zmq.ZMQ_IDENTITY,
new Buffer(uuid(), "ascii")
new Buffer.from(uuid(), "ascii")
);

// Bind to a random local port
Expand Down Expand Up @@ -248,7 +248,7 @@ describe("JMP messages", function() {
// Assign identity to client socket (only for testing purposes)
context.clientSocket.setsockopt(
zmq.ZMQ_IDENTITY,
new Buffer(uuid(), "ascii")
new Buffer.from(uuid(), "ascii")
);

// Bind to a random local port
Expand All @@ -271,7 +271,7 @@ describe("JMP messages", function() {

// The maximum length of a JS string in V8 is 0x1fffffe8 (536870888)
// See issue #35676 https://github.com/nodejs/node/issues/35676
messageFrames.unshift(new Buffer(512 * 1024 * 1024));
messageFrames.unshift(new Buffer.alloc(512 * 1024 * 1024));

jmp.Message._decode(
messageFrames, context.scheme, context.key
Expand Down