This repository was archived by the owner on Mar 8, 2018. It is now read-only.
Open
Conversation
Member
Author
|
Still to do:
|
chrismytton
force-pushed
the
26-per-field-sourcing
branch
from
8c62e3f to
bb0df16
Compare
chrismytton
force-pushed
the
26-per-field-sourcing
branch
from
e6ddddd to
d2c502c
Compare
Contributor
|
@chrismytton do you want me to design in a new branch from here? |
chrismytton
force-pushed
the
26-per-field-sourcing
branch
from
d2c502c to
c5e15f2
Compare
chrismytton
force-pushed
the
26-per-field-sourcing
branch
from
2b392d4 to
27991f0
Compare
The per-field sourcing feature is opt-in so we want it to be disabled by default.
At some point in the recent past, we switched from having read-mode and edit-mode elements next to each other, interspersed around the page, to having all the edit-mode elements in a separate template and collected at the end of the page, away from the read-mode ones. But many of the old read-mode and edit-mode elements were left in the templates, despite never actually being shown to users. This commit removes all the ones I could find. There might be more, but it's a start.
By separating the "Show source" button from the source "display" popup, we get more flexibilty over how the items are nested, which will come in useful for the crazy floating in the person/organization header. Separating the two elements requires the passing of some shared ID, so the JavaScript knows which buttons and popups to wire together. I wonder whether we could use the "field" attribute already passed to display-editing.html, instead of generating our own separate "sourceID" attribute?
chrismytton
force-pushed
the
26-per-field-sourcing
branch
from
27991f0 to
c7efd08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26