This repository was archived by the owner on Feb 15, 2019. It is now read-only.
Open
Conversation
Bugfix: if attribute's initial value is null, that it should be unset
Do not replace netsted model with new instance on .set('submodel', JSON)
Add commit event
Revert "Add commit event"
Add commit event and getLastCommitted method
Add ValidationAttributeError support
Add id attribute
previous method
Get attributes from instanse
Fixes for bem-promised-models
Collection
Validate method for model and collection attribute
collections and models errors fix
fix captureStackTrace
anton-kotenko
force-pushed
the
remove-done
branch
2 times, most recently
from
ede63f0 to
6c7792c
Compare
anton-kotenko
force-pushed
the
remove-done
branch
from
6c7792c to
0ca156d
Compare
km256
pushed a commit
to km256/promised-models
that referenced
this pull request
Feb 17, 2016
Performance issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove done's from calculate to avoid model freezing when amend/calculated fails