Open
Conversation
to make it compatible with drawAirportLinkPath
spencerm
reviewed
Jul 11, 2024
| } | ||
|
|
||
| def getLinksByAirplaneModel(modelId : Int) = Action { | ||
| val linksByModel = LinkSource.loadFlightLinksByAirplaneModel(airportId).groupBy(_.from) |
Collaborator
There was a problem hiding this comment.
@Bohaska the airportId here is not defined. Meanwhile the modelId is not being used.
Author
There was a problem hiding this comment.
I reused some code from the airport flight map function and forgot to change some of the parameters...
Yea, swap airportId with modelId
spencerm
reviewed
Jul 11, 2024
| def getLinksByAirplaneModel(modelId : Int) = Action { | ||
| val linksByModel = LinkSource.loadFlightLinksByAirplaneModel(airportId).groupBy(_.from) | ||
|
|
||
| val sortedLinks: Map[List[Airport], List[Link]] = links.foldLeft(Map.empty[List[Airport], List[Link]]) { (map, link) => |
Collaborator
There was a problem hiding this comment.
@Bohaska the links should probably be linksByModel ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flight map where you can view all flights that use a certain airplane model.
Note: I have not tested this. (and can't test the backend stuff)