Open
Conversation
Extracted actual fuel cost per barrel from existing fuelProfit data in AirlineSimulation.scala Formula used: actualFuelCostPerBarrel = actualFuelCost / barrelsUsed Leveraged existing contract calculation logic instead of duplicating it Integrate actual fuel cost into link simulation Added cache mechanism in LinkSimulation object to store actual fuel costs per airline Modified AirlineSimulation to calculate and store actual fuel cost per barrel Cache is cleared at the beginning of each cycle to ensure fresh data Update tax calculation to use actual fuel cost Modified computeLinkAndLoungeConsumptionDetail to use actual fuel cost when available Fuel tax now calculated based on actual fuel cost paid by airline (with contracts) rather than standard $70 price Fallback mechanism ensures backward compatibility when actual fuel cost is not available
Collaborator
|
Thanks for the PR! From a feature POV, personally I don't think this is going in the right direction because having a fixed fuelCost allows a player to compare flight profit between weeks (and graph them) without the huge swings of a fuel contract ending / starting. If we got rid of that, I'm sure players would frequently ask "why did my flight profits decrease 40%" without realizing why. The profit graphs would be less intuitive without a fixed cost. Technically looks like it'd work! However if we were to go in the above direction, we would have to remove the fuel contract line items from "other income" summing so we don't double count fuel contract revenue both there and in the flights income. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted actual fuel cost per barrel from existing fuelProfit data in AirlineSimulation.scala Formula used: actualFuelCostPerBarrel = actualFuelCost / barrelsUsed Leveraged existing contract calculation logic instead of duplicating it Integrate actual fuel cost into link simulation
Added cache mechanism in LinkSimulation object to store actual fuel costs per airline Modified AirlineSimulation to calculate and store actual fuel cost per barrel Cache is cleared at the beginning of each cycle to ensure fresh data Update tax calculation to use actual fuel cost
Modified computeLinkAndLoungeConsumptionDetail to use actual fuel cost when available Fuel tax now calculated based on actual fuel cost paid by airline (with contracts) rather than standard $70 price Fallback mechanism ensures backward compatibility when actual fuel cost is not available