This repository was archived by the owner on Sep 21, 2025. It is now read-only.
forked from RustAudio/lewton
-
Notifications
You must be signed in to change notification settings - Fork 0
refresh #1
Open
fdoyon
wants to merge
85
commits into
myNoise:master
Choose a base branch
from
RustAudio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refresh #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is deprecated since 1.33.0 and it has a default impl.
- Produce a C header instead of C++ - Report the license in the file
There is no sense in allocating a Vec and then immediately cloning it. Also make `mcos` to be big just enough to hold all the precalculated values.
Result of running: cargo update -p byteorder cargo update -p rental cargo update -p lazy_static cargo update -p cc --precise 1.0.41
Nightly Rust is warning about try being deprecated. Replacements like ? are much less powerful (at least on stable Rust 1.20.0 or even the stable Rust the warning will start to be shown on) so we won't switch.
7cefcfe to
bd9f523
Compare
* Add Windows environment * Cargo update Result of running: cargo update -p cc --precise 1.0.41 cargo update -p schannel --precise 0.1.8 * Run sample-rate-max test only on Linux
It breaks `cargo-c` otherwise.
Result of running: cargo update -p curl-sys --precise 0.4.9 cargo update -p vorbis --precise 0.1.0
* Upgrade smallvec 0.6 -> 1.1 Good to use stable & latest release of smallvec * Rust minimum version 1.20 -> 1.36 * Update Cargo.lock in dev/cmp
The slash "/" might be misinterpreted as "+". OR is more clear and gets the intent across more clearly (that there is a choice between the two licenses). Also set publish = false in dev/cmp
eaead05 to
1a9ca88
Compare
cmp tests seem to fail on windows as windows does not support sed in the way we need it.
There is the proc macro compat hack which will stop working in the future.
Fix word-o.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.