62 feature wechat share #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty string was translating as an empty span making other buttons larger than the wechat one
Owner
|
That's definitely interesting! Is a QR code the way people share things to wechat? Apart from that, I'm not a fan of the show-on-hover – I'd prefer if it showed-on-click and didn't open a new tab at all. Maybe with a checkbox hack? |
Contributor
Author
|
I tried the checkbox magic 😉 and did some SVG optimisation |
Owner
|
Hah, that's awesome, this is getting good! What about making the popup nicer, is there any easy wins styling-wise to not just make it a huge QR code? |
Contributor
Author
|
I tried to reorganise the react components to fit the QR code in more nicely. Tell me if it seems ok to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I added a Wechat share button as requested in issue #62.
The principle is a bit different than others share buttons as there is no Wechat web app for sharing.
The share button just displays a QR code so the user can open the website with Wechat on their mobile and share it from there.