Skip to content

Conversation

@developit
Copy link

Figured this was worth a shot - it also has the nice effect of taking the codebase from React 0.12.x (deprecated) to Preact 5.x (current).

Before: js/bundle.js = 64.4kb

After: js/bundle.js = 29.6kb

I've tested and everything seems to function identically.

@mxstbr
Copy link
Owner

mxstbr commented Aug 14, 2016

Woah this is extremely enticing, will give it some actual thoughts once I'm off this airplane! Thanks for doing this!

@mxstbr
Copy link
Owner

mxstbr commented Aug 18, 2016

In the deploy preview I'm not seeing the new WhatsApp button show up – any ideas why? Maybe needs to be rebased?

Other than that this sounds like a great idea, :shipit: !

@developit
Copy link
Author

Yup, I can rebase tonight.

@developit
Copy link
Author

@mxstbr Merged upstream changes and also updated to preact 6 & preact-compat 3.
The deploy preview looks on point! (also, I hadn't seen that Netlify feature before, pretty awesome)
Cheers! 🍻

@mxstbr
Copy link
Owner

mxstbr commented Aug 29, 2016

Something's off with the styling of the buttons. Current version:

screen shot 2016-08-29 at 10 17 44

Preact version:

screen shot 2016-08-29 at 10 17 48

Any ideas?

@developit
Copy link
Author

Saw that too - looks like it's the SVGs? I'll take a look - just wanted to make sure it wasn't something visible on master too

@developit
Copy link
Author

developit commented Aug 29, 2016

@mxstbr looks like React is inserting a <span> around the "Share to X" text, which is being used to add padding. This actually seems like something we'd want to change in the generated button code, since the span is missing (in both versions):

screen shot 2016-08-29 at 10 49 27 am

@mxstbr
Copy link
Owner

mxstbr commented Aug 30, 2016

That sounds reasonable, can you add that to this PR?

@olets
Copy link
Collaborator

olets commented Dec 1, 2016

@developit #71 should have the fix you need

@developit
Copy link
Author

Sweet. I should really update this PR haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants