-
Notifications
You must be signed in to change notification settings - Fork 104
Port to Preact: 50% size reduction, essentially no code changes #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Woah this is extremely enticing, will give it some actual thoughts once I'm off this airplane! Thanks for doing this! |
|
In the deploy preview I'm not seeing the new WhatsApp button show up – any ideas why? Maybe needs to be rebased? Other than that this sounds like a great idea, |
|
Yup, I can rebase tonight. |
|
@mxstbr Merged upstream changes and also updated to preact 6 & preact-compat 3. |
|
Saw that too - looks like it's the SVGs? I'll take a look - just wanted to make sure it wasn't something visible on master too |
|
@mxstbr looks like React is inserting a |
|
That sounds reasonable, can you add that to this PR? |
|
@developit #71 should have the fix you need |
|
Sweet. I should really update this PR haha |



Figured this was worth a shot - it also has the nice effect of taking the codebase from React 0.12.x (deprecated) to Preact 5.x (current).
Before:
js/bundle.js= 64.4kbAfter:
js/bundle.js= 29.6kbI've tested and everything seems to function identically.