Skip to content

[ISSUE #5335]✨Improve pull_request_hold_service accessor to return Option<&T> in BrokerRuntimeInner #5459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxsm merged 1 commit into from
Jan 6, 2026
Merged

[ISSUE #5335]✨Improve pull_request_hold_service accessor to return Option<&T> in BrokerRuntimeInner #5459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rocketmq-broker/src/broker_runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1809,8 +1809,8 @@ impl<MS: MessageStore> BrokerRuntimeInner<MS> {
}

#[inline]
pub fn pull_request_hold_service(&self) -> &Option<PullRequestHoldService<MS>> {
&self.pull_request_hold_service
pub fn pull_request_hold_service(&self) -> Option<&PullRequestHoldService<MS>> {
self.pull_request_hold_service.as_ref()
}

#[inline]
Expand Down
Loading