[ISSUE #5394]🧪Add test case for ExpressionType

[WaterWhisperer]

Which Issue(s) This PR Fixes(Closes)

Fixes #5394

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• Tests
  • Added comprehensive unit tests for expression type filtering to improve code reliability and ensure correct behavior of tag type validation logic.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[rocketmq-rust-bot]

🔊@WaterWhisperer 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

Walkthrough

This PR adds unit tests for the ExpressionType enum and is_tag_type() function in the rocketmq-common filter module, verifying string representations and validation logic without modifying public APIs.

Changes

Cohort / File(s)	Summary
ExpressionType Tests rocketmq-common/src/common/filter/expression_type.rs	Added #[cfg(test)] module with test_expression_type() function asserting enum string values (SQL92, TAG) and is_tag_type() behavior across None, empty, TAG, SQL92, and OTHER inputs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Tests take flight for types so clear,
SQL92, TAG—validation here!
Each assertion shines so bright,
Code now covered, safe and right! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding test cases for ExpressionType in the codebase.
Linked Issues check	✅ Passed	The PR successfully implements the requirement from issue #5394 by adding comprehensive test cases for ExpressionType with assertions covering both enum values and the is_tag_type function.
Out of Scope Changes check	✅ Passed	All changes are directly related to adding test cases for ExpressionType as specified in issue #5394; no out-of-scope modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rocketmq-common/src/common/filter/expression_type.rs (1)

30-44: LGTM! Comprehensive test coverage for ExpressionType.

The test module successfully covers all functionality:

• Both constants (SQL92 and TAG) are verified
• All branches of is_tag_type are tested with representative inputs (None, empty string, exact match, and non-matches)

The implementation is correct and fulfills the PR objectives.

Optional improvement: Consider splitting into focused test functions.

For slightly better test organization and failure reporting, you could optionally split this into two test functions:

🔎 Optional refactor

 #[cfg(test)]
 mod tests {
     use super::*;
 
     #[test]
-    fn test_expression_type() {
+    fn test_constants() {
         assert_eq!(ExpressionType::SQL92, "SQL92");
         assert_eq!(ExpressionType::TAG, "TAG");
+    }
+
+    #[test]
+    fn test_is_tag_type() {
         assert!(ExpressionType::is_tag_type(None));
         assert!(ExpressionType::is_tag_type(Some("")));
         assert!(ExpressionType::is_tag_type(Some("TAG")));
         assert!(!ExpressionType::is_tag_type(Some("SQL92")));
         assert!(!ExpressionType::is_tag_type(Some("OTHER")));
     }
 }

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35a20bb and 0d578e4.

📒 Files selected for processing (1)

• rocketmq-common/src/common/filter/expression_type.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Check (fmt + clippy)
• GitHub Check: auto-approve

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.84%. Comparing base (35a20bb) to head (0d578e4).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   37.83%   37.84%           
=======================================
  Files         811      811           
  Lines      109903   109912    +9     
=======================================
+ Hits        41582    41594   +12     
+ Misses      68321    68318    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rocketmq-rust-bot]

LGTM - All CI checks passed ✅